Add timestamp argument to STEP export #984
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing a timestamp value when exporting STEP files, to generate STEP files with a specific timestamp value in the file header.
For example, a null timestamp (
0000-00-00T00:00:00
), or a static timestamp can be used when generated files should be equal if there are no visual changes, such as for file versioning.This commit extends the
#export_step
function, to accept atimestamp
keyword argument, that can be a string or adatetime
object. Accepting adatetime
object makes it easier to use from Python, like a source file modification date.In
jgraichen/someline
I store the exported step files in the Git repository, but the current timestamp in the file always results in changes. I use them there in a CI pipeline to ensure that the code always generates the same models as before.Currently, I have to strip the timestamp after the export. Passing a
timestamp
directly when exporting would make it much easier and directly allow reproducible builds.Some formatting changes are from
black
, some imports were not used anymore.