Bugfix: correct ArcArcTangentArc tangency with reversed start_arc in algebra mode
#1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter on incorrect side to resolve gumyr#983
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1000 +/- ##
==========================================
- Coverage 96.94% 96.70% -0.25%
==========================================
Files 32 32
Lines 9893 10066 +173
==========================================
+ Hits 9591 9734 +143
- Misses 302 332 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good to me, thanks for working on this! |
|
Thank you! You got #1000 - congratulations! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
start_archas a reversed direction resulting in a negative plane normal in algebra mode, the resulting arc was drawn with the center facing the wrong way.ArcArcTangentArcnow checks the tangency of the resulting arc and flips the arc if necessary.Resolves #983
black did some unrelated formatting I left in.