-
Notifications
You must be signed in to change notification settings - Fork 5
Add mParticle Data Subject Request (DSR) API Integration #2854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnduffell
reviewed
May 29, 2025
johnduffell
reviewed
May 29, 2025
johnduffell
reviewed
May 29, 2025
johnduffell
reviewed
May 29, 2025
johnduffell
reviewed
May 29, 2025
johnduffell
reviewed
May 29, 2025
johnduffell
reviewed
May 29, 2025
johnduffell
reviewed
May 29, 2025
…s and streamline response handling
…rt-service-lambdas into afs-mparticle-api
…e duplicate import
…d improve type safety in tests
…rt-service-lambdas into afs-mparticle-api
…improved type safety and error handling
this seems to have failed to deploy to PROD |
the new lambda code needed to be copied to S3 before the CDK could be deployed. I did that and now it's all passed https://riffraff.gutools.co.uk/deployment/view/feffc250-fd05-49a7-a7aa-0a338e18aa59 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Collecting workspace informationWhat does this change?
This PR introduces a new AWS Lambda function, written in TypeScript, that integrates with the mParticle Data Subject Request (DSR) API. The Lambda automates the submission, tracking, and processing of data subject requests (DSRs) to mParticle, supporting The Guardian’s compliance with privacy regulations such as GDPR and CCPA. This new development was made in the context of this Trello ticket. Key features include:
How to test
Install dependencies:
Run
pnpm install
from the root of the repo.Build:
Run
pnpm --filter mparticle-api build
to build the Lambda.Run locally:
Use
npm run run-local -- --file=path/to/request.json
to invoke the Lambda locally with a test event.Unit tests:
Run
pnpm --filter mparticle-api test
to execute all tests for this Lambda.Environment variables:
Ensure mParticle API credentials and other secrets are available via AWS Secrets Manager in deployed environments, or via a
.env
file for local development.Manual testing:
Use example payloads from the
runs/
directory and verify API responses for all endpoints.How can we measure success?
Have we considered potential risks?
All these risks are mitigated by strong input validation, comprehensive testing, and clear error logging as described in the README.
Images
N/A - This is a backend API integration with no visual components.
Accessibility
N/A - This change implements a backend API handler with no user-facing interface elements.