Add AppNexus targeting to Sonobi bid request #18896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rich-nguyen
approved these changes
Jan 15, 2018
rich-nguyen
reviewed
Jan 15, 2018
| @@ -60,6 +60,7 @@ export const sonobiBidder: PrebidBidder = { | |||
| ad_unit: config.page.adUnit, | |||
| dom_id: slotId, | |||
| floor: 0.5, | |||
| appNexusTargeting: config.page.appNexusPageTargeting, | |||
There was a problem hiding this comment.
You should ensure there is a dependency on this:
https://github.com/guardian/frontend/blob/master/static/src/javascripts/projects/commercial/modules/build-page-targeting.js#L165
To ensure that AppNexus targeting is available to the Sonobi bidder.
kelvin-chappell
force-pushed
the
kc-prebid-sonobi
branch
from
eecaf6e to
6fd73c6
Compare
|
PRbuilds results: Screenshots 💚 Exceptions 🔥 (failed) A11y validation Apache Benchmark Load Testing 🔥 (invalid) Microdata Validation --automated message |
rich-nguyen
approved these changes
Jan 16, 2018
|
Overdue on PROD (merged by @kelvin-chappell 30 minutes and 5 seconds ago) What's gone wrong? |
kelvin-chappell
added
the
Commercial: Programmatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make new prebid setup functionally equivalent to old Sonobi wrapper setup.
Depends on guardian/Prebid.js#3