This repository was archived by the owner on Mar 12, 2025. It is now read-only.
122 bid won event #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeteve
force-pushed
the
122-bidWon-event
branch
2 times, most recently
from
2bc0375 to
a0ef504
Compare
| let ev = analyticsAdapter.context.queue.peekAll(); | ||
| expect(ev).to.have.length(0); // The queue has been flushed. | ||
| ev = JSON.parse(ajaxStub.firstCall.args[2]).hb_ev; | ||
| expect(ev[0]).to.be.eql({ev: 'bidwon', aid: '5018eb39-f900-4370-b71e-3bb5b48d324f', bid: BIDONE.bidId , sid: BIDONE.adUnitCode }); |
There was a problem hiding this comment.
Do we need the ad unit code?
| }], | ||
| }; | ||
|
|
||
| const REQUEST1 = { |
There was a problem hiding this comment.
Not sure why these are in uppercase. Perhaps I copied it from somewhere.
| } | ||
| if (handler) { | ||
| let events = handler(args); | ||
| if (events && analyticsAdapter.context.queue) { | ||
| analyticsAdapter.context.queue.push(events); | ||
| } | ||
| if (eventType === CONSTANTS.EVENTS.AUCTION_END) { | ||
| if ( SENDALL_ON[eventType] ) { |
| undefined, // timeToRespond | ||
| undefined, // startTime | ||
| args.bidId | ||
| ); |
There was a problem hiding this comment.
I think we only need 'bidWon', auctionId and bidId.
There was a problem hiding this comment.
Yep. I will remove all the other stuff :)
arelra
pushed a commit
that referenced
this pull request
Feb 5, 2024
* add Rise adapter * fixes * change param isOrg to org * Rise adapter * change email for rise * fix circle failed * bump * bump * bump * remove space * Upgrade Rise adapter to 5.0 * added isWrapper param * addes is_wrapper parameter to documentation * added is_wrapper to test * removed isWrapper * Rise Bid Adapter: support Coppa param (#24) * MinuteMedia Bid Adapter: support Coppa param (#25) * Revert "MinuteMedia Bid Adapter: support Coppa param (#25)" (#26) This reverts commit 66c4e7b. * bump * update coppa fetch * setting coppa param update * update Coppa tests * update test naming * Rise Bid Adapter: support plcmt and sua (#27) * update minuteMediaBidAdapter - support missing params (#29) * RIseBidAdapter: support currency (#35) --------- Co-authored-by: Noam Tzuberi <[email protected]> Co-authored-by: noamtzu <[email protected]> Co-authored-by: Noam Tzuberi <[email protected]> Co-authored-by: Laslo Chechur <[email protected]> Co-authored-by: OronW <[email protected]> Co-authored-by: lasloche <[email protected]> Co-authored-by: inna <[email protected]> Co-authored-by: YakirLavi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the guAnalytics side of https://trello.com/c/d6JaB1Jh
It sends the BidWon event (so when the winning bid effectively fills the Ad slot instead of Google) on its own to be later processed by the Prebid ETL job(s).