(De)compress ZLib compressed fields during (de)serialisation of messages #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigglesss
changed the title
bigglesss
force-pushed
the
biggle--decompress-zlib-tagged-members
branch
from
7697a04 to
c0f6dea
Compare
gtker
requested changes
Oct 8, 2022
wow_message_parser/src/rust_printer/structs/print_common_impls/mod.rs
Outdated
Show resolved
Hide resolved
gtker
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only supports u8 buffers at the moment, going to see how tricky handling the conversion into proper types looks, but this is a working tested implementation of basic (de)serialisation, with tests fixed up.
All ZLib code is in the writing/reading functions, so the struct only ever contains the uncompressed version of the data, hence the change in field name.