Skip to content

A61 update: remove special case for LOGICAL_DNS clusters #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2025
Merged

A61 update: remove special case for LOGICAL_DNS clusters #477

merged 3 commits into from
Mar 6, 2025

Conversation

markdroth
Copy link
Member

No description provided.

@markdroth markdroth requested review from ejona86 and dfawley March 1, 2025 00:33
@markdroth markdroth mentioned this pull request Mar 1, 2025
Closed
ejona86
ejona86 reviewed Mar 6, 2025
View reviewed changes
ejona86
ejona86 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for posterity: it is safe to combine DNS results into a single endpoint because their attributes will be the same. Even with SRV records, since A26, DNS doesn't return the grpclb addresses mixed with the regular addresses.

@dfawley dfawley mentioned this pull request Mar 6, 2025
Open
@markdroth
Copy link
Member Author

@murgatroid99 FYI.

@markdroth markdroth merged commit b1dd022 into grpc:master Mar 6, 2025
1 check passed
@markdroth markdroth deleted the A61_update_logical_dns_in_single_endpoint branch March 6, 2025 22:07
copybara-service bot pushed a commit to grpc/grpc that referenced this pull request Mar 11, 2025
@markdroth @copybara-github
[xDS] for logical_dns clusters, use a single endpoint instead of hard…
6a7816a 
…-coding pick_first (#38248)

See grpc/proposal#477 for context.

Closes #38248

COPYBARA_INTEGRATE_REVIEW=#38248 from markdroth:xds_logical_dns_all_addresses_in_one_endpoint 4cfa6ee
PiperOrigin-RevId: 735820369
@arjan-bal arjan-bal mentioned this pull request Jun 3, 2025
Closed
@murgatroid99 murgatroid99 mentioned this pull request Jun 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@dfawley dfawley dfawley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markdroth @ejona86 @dfawley