Bazel: Fix compilation in Java 9 #4325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: grpc#3633. Test Plan: On most recent Bazel version run: $ bazel --host_javabase=/usr/lib64/jvm/java-9-openjdk \ build --javacopt='--release 9' \ --java_toolchain=@bazel_tools//tools/jdk:toolchain_jdk9 \ examples:helloworld_java_grpc
ejona86
reviewed
Apr 26, 2018
repositories.bzl
Outdated
| native.http_file( | ||
| name = "javax_annotation_api", | ||
| sha256 = "e04ba5195bcd555dc95650f7cc614d151e4bcd52d29a10b8aa2197f3ab89ab9b", | ||
| urls = ["http://central.maven.org/maven2/javax/annotation/javax.annotation-api/1.3.2/javax.annotation-api-1.3.2.jar"], |
There was a problem hiding this comment.
We use version 1.2 in build.gradle and like to keep the versions in sync. 1.3.2 also doesn't support Java 7 (although I honestly don't know if Bazel supports Java 7). Let's change this to version 1.2 (unless there's some problem with doing so).
core/BUILD.bazel
Outdated
| # javax.annotation.Generated is not included in the default root modules in 9, | ||
| # see: http://openjdk.java.net/jeps/320. | ||
| java_import( | ||
| name = "javax_annotation", |
There was a problem hiding this comment.
Technically, having this in core seems a bad idea, but we don't have a third_party/ yet, so this seems good enough for now.
There was a problem hiding this comment.
Maybe in stub is more appropriate than core, although not as good as third_party.
There was a problem hiding this comment.
I moved the new javax_annotation rule to stub package instead of core. Done.
|
Thank you for this! |
ejona86
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
Use the same version as in gradle build.
ejona86
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
ejona86
approved these changes
Apr 26, 2018
dapengzhang0
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3633.
Test Plan:
On most recent Bazel version run: