core: allow application to provide all threads - inprocess channel #4139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Feb 26, 2018
| return new InProcessServer(name, GrpcUtil.TIMER_SERVICE, streamTracerFactories); | ||
| ObjectPool<ScheduledExecutorService> schedulerPool = | ||
| scheduledExecutorService == null | ||
| ? SharedResourcePool.forResource(GrpcUtil.TIMER_SERVICE) |
There was a problem hiding this comment.
Use a ObjectPool field instead of ScheduledExecutorService and make this the default value. Then in the scheduledExecutorService() method overwrite it with the FixedObjectPool.
You could do this pattern in InProcessChannelBuilder as well.
There was a problem hiding this comment.
Fixed. The pattern does not provide much gain for InProcessChannelBuilder, and currently it's in the same pattern as NettyChannelBuilder and OkHttpChannelBuilder.
| @@ -55,13 +52,6 @@ static InProcessServer findServer(String name) { | |||
| */ | |||
There was a problem hiding this comment.
You need to update schedulerPool's documentation.
ejona86
approved these changes
Feb 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is one of a sequence of PRs to allow application to provide all threads.
This PR added
InProcess{Channel, Server}Builder.scheduledExecutorService()API