core,netty: InputStream support in SslContextBuilder #3485
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update unit tests to stop writing certs to temp files. Fixes grpc#1881
ejona86
reviewed
Sep 21, 2017
| * @throws UnsupportedOperationException if the server does not support TLS. | ||
| * @since 1.7.0 | ||
| */ | ||
| public abstract T useTransportSecurity(InputStream certChain, InputStream privateKey); |
There was a problem hiding this comment.
We can't add new abstract methods to public classes. We need to convert to File or throw.
| try { | ||
| return configure(SslContextBuilder.forServer(keyCertChain, key)); | ||
| } finally { | ||
| GrpcUtil.closeQuietly(keyCertChain); |
There was a problem hiding this comment.
Normally the creator of the InputStream closes (e.g., with try-with-resources). But also this is supposed to act effectively the same as Netty's SslContextBuilder. I don't think we should be closing here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update unit tests to stop writing certs to temp files.
Fixes #1881