Skip to content

xds/internal: update generic grpctransport codec name to proto #8368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

purnesh42H
Copy link
Contributor

RELEASE NOTES: None

@purnesh42H purnesh42H requested a review from dfawley May 28, 2025 15:45
@purnesh42H purnesh42H added Type: Internal Cleanup Refactors, etc Area: xDS Includes everything xDS related, including LB policies used with xDS. labels May 28, 2025
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (ec4810c) to head (bfa1241).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8368      +/-   ##
==========================================
- Coverage   82.22%   82.17%   -0.06%     
==========================================
  Files         419      419              
  Lines       42047    42049       +2     
==========================================
- Hits        34574    34552      -22     
- Misses       6003     6030      +27     
+ Partials     1470     1467       -3     
Files with missing lines Coverage Δ
...s/internal/clients/grpctransport/grpc_transport.go 89.81% <100.00%> (+0.19%) ⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@purnesh42H purnesh42H added this to the 1.74 Release milestone May 28, 2025
return "grpctransport.byteCodec"
// Return "proto" to ensure the Content-Type header is "application/grpc",
// which is expected by standard gRPC servers for protobuf messages.
return proto.Name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "proto" please.

@dfawley dfawley assigned purnesh42H and unassigned dfawley May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants