interop: let the interop client set the universe domain based on a flag #8201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8201 +/- ##
==========================================
- Coverage 82.25% 81.97% -0.29%
==========================================
Files 393 410 +17
Lines 39143 40216 +1073
==========================================
+ Hits 32197 32966 +769
- Misses 5616 5880 +264
- Partials 1330 1370 +40 🚀 New features to boost your workflow:
|
easwars
previously approved these changes
Mar 26, 2025
| @@ -82,6 +82,7 @@ var ( | |||
| soakResponseSize = flag.Int("soak_response_size", 314159, "The response size in a soak RPC. The default value is set based on the interop large unary test case.") | |||
| soakNumThreads = flag.Int("soak_num_threads", 1, "The number of threads for concurrent execution of the soak tests (rpc_soak or channel_soak). The default value is set based on the interop large unary test case.") | |||
| tlsServerName = flag.String("server_host_override", "", "The server name used to verify the hostname returned by TLS handshake if it is not empty. Otherwise, --server_host is used.") | |||
| universeDomain = flag.String("universe_domain", "", "The universe domain in which the process is running. If blank, the process is assumed to be running in the default universe.") | |||
|
Looks like there is already #8145 which is blocked on grpc/grpc#38933 to finalize the flag name. I'm closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
@apolcyn
RELEASE NOTES: none