delegatingresolver: Call ResolveNow in a new goroutine to avoid deadlocks #8199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While handling updates from child resolvers, the delegating resolver locks it's mutex. If the channel returns an error on updating the state, the delegating resolver calls
ResolveNow
on the other child. This can result in a deadlock if the other child attempts to callcc.UpdateState
synchronously while handling theResolveNow
call. This change makes delegatingResovler callResolveNow
in a new goroutine to avoid such deadlocks.RELEASE NOTES:
UpdateState
synchronously while handling aResolveNow
call.