bugfix: disable IOReaderFactory for streaming requests #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happyalu
force-pushed
the
happyalu/bugfix/readAll
branch
from
46fefbe to
5f06474
Compare
johanbrandhorst
requested changes
Mar 6, 2019
|
Could you try building the grpc-gateway generator off this branch and see if it fixes tmc/grpc-websocket-proxy#14 for you? |
An IOReaderFactory was being used to wrap request body for client/bidi streaming requests. This was causing the requests to be fully buffered before being sent to the grpc server, thereby breaking streaming. This commit changes that to directly use request body.
happyalu
force-pushed
the
happyalu/bugfix/readAll
branch
from
5f06474 to
5bf89d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
=======================================
Coverage 53.69% 53.69%
=======================================
Files 39 39
Lines 3926 3926
=======================================
Hits 2108 2108
Misses 1621 1621
Partials 197 197
Continue to review full report at Codecov.
|
Yes, my websocket client is working again. |
johanbrandhorst
approved these changes
Mar 6, 2019
|
Thank you so much for this contribution! |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
An IOReaderFactory was being used to wrap request body for client/bidi streaming requests. This was causing the requests to be fully buffered before being sent to the grpc server, thereby breaking streaming. This commit changes that to directly use request body. Fixes grpc-ecosystem#894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An IOReaderFactory was being used to wrap request body for client/bidi streaming
requests. This was causing the requests to be fully buffered before being sent
to the grpc server, thereby breaking streaming. This commit changes that to
directly use request body.
Fixes #894