-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Draft: Add openapi v3 #5627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Draft: Add openapi v3 #5627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for taking the time to look into this. It's going to be hard for me to review this the way it's currently written. It seems to be based a lot on the existing generator. Could you talk to me about the process you used to build this? I explicitly said that I want us to start from scratch with this generator and not rely on existing code, if we can avoid it. I would remove basically all the flags too and add them piece by piece. Did you use AI to build this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file?
Hi, |
I'm also a little bit unfamiliar with bazel. I will fix the bazel config to not generate the swagger files |
7eab375
to
48b4c88
Compare
5592b8d
to
5811515
Compare
5811515
to
f912d21
Compare
References to other Issues or PRs
This feature was request in #441.
Have you read the Contributing Guidelines?
Brief description of what is fixed or changed
This is a minimal implementation (as I'm writing this description a draft) for openapiv3 protoc plugin.
Other comments
I plan to add tests and complete other features. I just want to get this look at before I go all in.
Right now it generates OpenAPI spec version 3, using
kin-openapi
library.