Skip to content

feat(bazel): surface --preserve_rpc_order in rule def #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lennrt
Copy link
Contributor

@lennrt lennrt commented Mar 11, 2025

References to other Issues or PRs

Fixes #5349

Have you read the Contributing Guidelines?

Yes

Brief description of what is fixed or changed

This change surfaces the --preserve_rpc_order flag for the OpenAPI spec generator in the protoc_gen_openapiv2 Bazel rule.

Other comments

The --preserve_rpc_order flag was implemented in #3500

https://grpc-ecosystem.github.io/grpc-gateway/docs/mapping/customizing_openapi_output/#preserve-rpc-path-order

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We really should have some way to ensure that his happens when new flags are added 😬.

@johanbrandhorst johanbrandhorst enabled auto-merge (squash) March 11, 2025 21:51
@johanbrandhorst johanbrandhorst merged commit f1c8b2a into grpc-ecosystem:main Mar 11, 2025
14 checks passed
@johanbrandhorst
Copy link
Collaborator

Thank you for your contribution!

rohitlohar45 pushed a commit to rohitlohar45/grpc-gateway that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support option in Bazel rule to preserve RPC path order
3 participants