Skip to content

utilities: move package to public API #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2020
Merged

utilities: move package to public API #1395

merged 1 commit into from
May 25, 2020

Conversation

johanbrandhorst
Copy link
Collaborator

This was made internal, but it's actually used
by the generated files.

This was made internal, but it's actually used
by the generated files.
@codecov-commenter
Copy link

Codecov Report

Merging #1395 into v2 will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2    #1395   +/-   ##
=======================================
  Coverage   58.82%   58.82%           
=======================================
  Files          32       32           
  Lines        3891     3891           
=======================================
  Hits         2289     2289           
  Misses       1349     1349           
  Partials      253      253           
Impacted Files Coverage Δ
internal/httprule/compile.go 100.00% <ø> (ø)
...-gen-grpc-gateway/internal/gengateway/generator.go 37.86% <0.00%> (ø)
...c-gen-grpc-gateway/internal/gengateway/template.go 79.79% <ø> (ø)
runtime/pattern.go 88.43% <ø> (ø)
runtime/query.go 65.19% <ø> (ø)
utilities/readerfactory.go 0.00% <ø> (ø)
utilities/trie.go 92.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc95ab4...671972f. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 877d598 into v2 May 25, 2020
@johanbrandhorst johanbrandhorst deleted the export-utilities branch May 25, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants