Skip to content

Rename protoc-gen-swagger to protoc-gen-openapi #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 25, 2020
Merged

Conversation

johanbrandhorst
Copy link
Collaborator

No description provided.

@achew22
Copy link
Collaborator

achew22 commented May 25, 2020

Do you want to specify v2?

@achew22
Copy link
Collaborator

achew22 commented May 25, 2020

To be clear openapi v2?

@johanbrandhorst
Copy link
Collaborator Author

That would force us to rewrite it with a new name if we wanted to support v3 right?

@johanbrandhorst
Copy link
Collaborator Author

To be clear openapi v2?

Thinking more about this, I think you're right. I'll rename the binary

@codecov-commenter
Copy link

Codecov Report

Merging #1390 into v2 will not change coverage.
The diff coverage is 48.08%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2    #1390   +/-   ##
=======================================
  Coverage   58.82%   58.82%           
=======================================
  Files          32       32           
  Lines        3891     3891           
=======================================
  Hits         2289     2289           
  Misses       1349     1349           
  Partials      253      253           
Impacted Files Coverage Δ
internal/descriptor/registry.go 59.61% <0.00%> (ø)
...toc-gen-openapiv2/internal/genopenapi/generator.go 9.09% <0.00%> (ø)
...rotoc-gen-openapiv2/internal/genopenapi/helpers.go 0.00% <ø> (ø)
protoc-gen-openapiv2/main.go 26.12% <0.00%> (ø)
runtime/mux.go 58.87% <ø> (ø)
protoc-gen-openapiv2/internal/genopenapi/types.go 17.39% <33.33%> (ø)
...otoc-gen-openapiv2/internal/genopenapi/template.go 57.65% <57.61%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1189f2c...bb2fe4f. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 2ee1c8c into v2 May 25, 2020
@johanbrandhorst johanbrandhorst deleted the rename-swagger branch May 25, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants