Xin/support deep levels reserved json name #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1191 +/- ##
==========================================
+ Coverage 54.15% 54.46% +0.30%
==========================================
Files 42 42
Lines 4297 4326 +29
==========================================
+ Hits 2327 2356 +29
Misses 1712 1712
Partials 258 258
Continue to review full report at Codecov.
|
|
@johanbrandhorst , I am working on a test, will push another commit. |
|
@johanbrandhorst , I finalized the PR. It is ready for review. |
johanbrandhorst
requested changes
Mar 29, 2020
| if strings.Contains(fieldName, ".") { | ||
| fieldNames := strings.Split(fieldName, ".") | ||
| fieldNamesWithCamelCase := make([]string, 0) | ||
| for _, oneField := range fieldNames[:len(fieldNames) - 1] { |
There was a problem hiding this comment.
Is this slicing necessary?
There was a problem hiding this comment.
Good point! Fixing it now.
johanbrandhorst
approved these changes
Mar 29, 2020
|
@johanbrandhorst , good call! I tested on my side using the @brocaar 's example, it worked. |
|
Thanks for your contribution! |
|
@johanbrandhorst , anytime! |
|
Thanks @xin-au for the quick response and fix! 👍 |
|
@brocaar , anytime! |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
* Add message as another argument for supporting deep level reserved json name * Get reserved json name in non direct field of a grpc method * Change variable names based on google naming policy * Change variable names based on google naming policy in test * Reuse variable value * Format code * Update test names * Add doCamelCase and one more test case * Correct a comment in test * Keep all prefix in camel case * Use regular for loop instead of foreach to avoid unnecessary slicing * Update protoc-gen-swagger/genswagger/template_test.go Co-Authored-By: Johan Brandhorst <[email protected]> * Add space in comments * Remove a unnecessary comment Co-authored-by: Johan Brandhorst <[email protected]>
pull bot
pushed a commit
to BuildingRobotics/grpc-gateway
that referenced
this pull request
Apr 29, 2020
* Add message as another argument for supporting deep level reserved json name * Get reserved json name in non direct field of a grpc method * Change variable names based on google naming policy * Change variable names based on google naming policy in test * Reuse variable value * Format code * Update test names * Add doCamelCase and one more test case * Correct a comment in test * Keep all prefix in camel case * Use regular for loop instead of foreach to avoid unnecessary slicing * Update protoc-gen-swagger/genswagger/template_test.go Co-Authored-By: Johan Brandhorst <[email protected]> * Add space in comments * Remove a unnecessary comment Co-authored-by: Johan Brandhorst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting deep levels reserved json name. Regarding the issue #1187