Skip to content

TestOutgoingTrailerMatcher is non-deterministic #4264

Closed
@joshgarnett

Description

@joshgarnett

PR #4259 added comparing the headers in TestOutgoingTrailerMatcher. While working on another PR, I noticed that this would sometimes fail when the github hooks run the tests. This is caused by the TrailerMD being a map, which has a non-deterministic read order. A simple fix is to just sort the headers received before comparing.

I'll create a PR shortly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions