-
Notifications
You must be signed in to change notification settings - Fork 167
Add streaming message receive and send histograms #71
Add streaming message receive and send histograms #71
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
0c422c3
to
a924bff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked it (:
Some typos though (or am I wrong?)
Not sure what to do with tests though. I mean I don't think this project is buildable got Go 1.9.
As tmp thing you can comment all version BELOW Go 1.9 in Travis as even master does not work on those. @domgreen?
Co-Authored-By: povilasv <[email protected]>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
c5d1bc8
to
823ddd9
Compare
@bwplotka could you confirm this :D and set cla label to yes |
Lol ;p |
No description provided.