-
Notifications
You must be signed in to change notification settings - Fork 272
Start to stub in categorize section #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These stubs will be very helpful for participants to start working on various subsections. At first, I was somewhat confused which text was an initial draft for the review and which was guidelines for the authors. Perhaps use italics for prompts and suggestions?
@agitter : totally agree that italics for prompts and suggestions would be most helpful. I'll convert to that (and fix a couple of the markdown issues that CC noted). Thanks! |
I added a placeholder for background information on deep learning, which came up in #116. |
@agitter : ok - tried to address. Some of the codeclimate issues will take care of themselves as we write and clarify our thoughts (e.g. header length/punctuation). Basically these are all stubs to be replaced. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments only. In one, (sections/02_intro.md
) I think there is a mistake in the markdown
### If this happens, is deep learning required for any of it? Are we any closer | ||
### because of the advent of deep learning? | ||
|
||
* "Categorize" and "treat" sound a bit like PMI goals. Another way to think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you meant to bullet this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, can you expand the acronym for PMI the first time you reference it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bullets here (and elsewhere) seem to be induced by atom's convenient "reflow selection" functionality. I tracked it down here and in the other part, and expanded PMI. Thanks!
Intro goes here. | ||
### Potential writing prompt | ||
|
||
One potential future that we could imagine is a world in which data, once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely agree with the three subcategories and the content of this stub.
But, for consistency, can you mention them either before or after the period? Right now I am not sure which sentences (CATEGORIZE)
or (TREAT)
are referencing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gwaygenomics : removed them for now. We'll see how the sections come along to decide what to talk about specifically.
My comments have been addressed |
@gwaygenomics : let me know if I've addressed all of your comments! thanks! |
Start to stub in categorize section
Fix upstream issues: Extra brackets around citations in figure captions jgm/pandoc#4272 WeasyPrint 0.42 gets stuck Kozea/WeasyPrint#560 Updated pandoc-xnos with better semantic versioning tomduck/pandoc-fignos#46
Includes chunks that someone can bite off if they want to focus on a specific area for writing.