Skip to content

Start to stub in categorize section #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 25, 2016
Merged

Start to stub in categorize section #108

merged 9 commits into from
Oct 25, 2016

Conversation

cgreene
Copy link
Member

@cgreene cgreene commented Oct 13, 2016

Includes chunks that someone can bite off if they want to focus on a specific area for writing.

Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These stubs will be very helpful for participants to start working on various subsections. At first, I was somewhat confused which text was an initial draft for the review and which was guidelines for the authors. Perhaps use italics for prompts and suggestions?

@cgreene
Copy link
Member Author

cgreene commented Oct 21, 2016

@agitter : totally agree that italics for prompts and suggestions would be most helpful. I'll convert to that (and fix a couple of the markdown issues that CC noted). Thanks!

@agitter
Copy link
Collaborator

agitter commented Oct 24, 2016

I added a placeholder for background information on deep learning, which came up in #116.

@cgreene
Copy link
Member Author

cgreene commented Oct 25, 2016

@agitter : ok - tried to address. Some of the codeclimate issues will take care of themselves as we write and clarify our thoughts (e.g. header length/punctuation). Basically these are all stubs to be replaced. Thanks!

Copy link
Contributor

@gwaybio gwaybio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only. In one, (sections/02_intro.md) I think there is a mistake in the markdown

### If this happens, is deep learning required for any of it? Are we any closer
### because of the advent of deep learning?

* "Categorize" and "treat" sound a bit like PMI goals. Another way to think
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to bullet this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, can you expand the acronym for PMI the first time you reference it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bullets here (and elsewhere) seem to be induced by atom's convenient "reflow selection" functionality. I tracked it down here and in the other part, and expanded PMI. Thanks!

Intro goes here.
### Potential writing prompt

One potential future that we could imagine is a world in which data, once
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely agree with the three subcategories and the content of this stub.

But, for consistency, can you mention them either before or after the period? Right now I am not sure which sentences (CATEGORIZE) or (TREAT) are referencing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gwaygenomics : removed them for now. We'll see how the sections come along to decide what to talk about specifically.

@agitter
Copy link
Collaborator

agitter commented Oct 25, 2016

My comments have been addressed

@cgreene
Copy link
Member Author

cgreene commented Oct 25, 2016

@gwaygenomics : let me know if I've addressed all of your comments! thanks!

@cgreene cgreene merged commit bab03da into master Oct 25, 2016
@cgreene cgreene deleted the categorize-draft branch October 25, 2016 12:31
dhimmel pushed a commit to dhimmel/deep-review that referenced this pull request Nov 3, 2017
dhimmel added a commit to dhimmel/deep-review that referenced this pull request Feb 16, 2018
Fix upstream issues:

Extra brackets around citations in figure captions
jgm/pandoc#4272

WeasyPrint 0.42 gets stuck
Kozea/WeasyPrint#560

Updated pandoc-xnos with better semantic versioning
tomduck/pandoc-fignos#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants