feat(Rtd): add a flag to disable the filtering of rtd module #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/greenbidsRtdProvider.js
Outdated
| @@ -85,6 +85,7 @@ function processSuccessResponse(response, timeoutId, reqBidsConfigObj, greenbids | |||
|
|
|||
| function updateAdUnitsBasedOnResponse(adUnits, responseAdUnits, greenbidsId) { | |||
| const isFilteringForced = getParameterByName('greenbids_force_filtering'); | |||
| const isFilteringDisabled = getParameterByName('greenbids_disabled_filtering'); | |||
There was a problem hiding this comment.
Stay consistent with the other parameter name.
Suggested change
| const isFilteringDisabled = getParameterByName('greenbids_disabled_filtering'); | |
| const isFilteringDisabled = getParameterByName('greenbids_disable_filtering'); |
modules/greenbidsRtdProvider.js
Outdated
Comment on lines
97
to
102
| if (isFilteringForced) { | ||
| adUnit.bids = []; | ||
| logInfo('Greenbids Rtd: filtering flag detected, forcing filtering of Rtd module.'); | ||
| } else if (!matchingAdUnit.isExploration) { | ||
| } else if (!matchingAdUnit.isExploration & !isFilteringDisabled) { | ||
| removeFalseBidders(adUnit, matchingAdUnit); | ||
| } |
There was a problem hiding this comment.
suggestion: may I ask to rewrite the condition to make it more straight forward?
Suggested change
| if (isFilteringForced) { | |
| adUnit.bids = []; | |
| logInfo('Greenbids Rtd: filtering flag detected, forcing filtering of Rtd module.'); | |
| } else if (!matchingAdUnit.isExploration) { | |
| } else if (!matchingAdUnit.isExploration & !isFilteringDisabled) { | |
| removeFalseBidders(adUnit, matchingAdUnit); | |
| } | |
| if (matchingAdUnit.isExploration || isFilteringDisabled) return; // Or you may log something | |
| if (isFilteringForced) { | |
| ... | |
| } else { | |
| removeFalseBidders(...); | |
| } |
AlexisBRENON
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information