-
Notifications
You must be signed in to change notification settings - Fork 5
distinctBy를 추가하고 distinct를 변경합니다. #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,10 +77,15 @@ let indexBy: (array<'a>, 'a => 'b, ~id: Belt.Map.id<'b, 'c>) => Belt.Map.t<'b, ' | |
*/ | ||
let frequencies: (array<'a>, ~id: Belt.Map.id<'a, 'b>) => Belt.Map.t<'a, int, 'b> | ||
|
||
/** | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: distinct와 순서를 바꾸면 좋겠습니다 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
NonEmpty의 distinct, distinctBy와 순서가 달라서라면 NonEmpty의 순서를 바꿔도 좋을 것 같습니다! |
||
먼저 등장하는 순서를 유지하면서 키에 따라 중복 원소를 제거합니다. | ||
*/ | ||
let distinctBy: (array<'a>, 'a => 'b) => array<'a> | ||
|
||
/** | ||
먼저 등장하는 순서를 유지하면서 중복 원소를 제거합니다. | ||
*/ | ||
let distinct: (array<'a>, ~id: Belt.Set.id<'a, 'b>) => array<'a> | ||
let distinct: array<'a> => array<'a> | ||
|
||
/** | ||
`reduce`와 비슷하나 중간 결과를 모두 포함한 `array`를 반환합니다. | ||
|
@@ -258,7 +263,9 @@ module NonEmpty: { | |
|
||
let frequencies: (t<'a>, ~id: Belt.Map.id<'a, 'b>) => Belt.Map.t<'a, int, 'b> | ||
|
||
let distinct: (t<'a>, ~id: Belt.Set.id<'a, 'b>) => t<'a> | ||
let distinct: t<'a> => t<'a> | ||
|
||
let distinctBy: (t<'a>, 'a => 'b) => t<'a> | ||
|
||
let scan: (t<'a>, 'b, ('b, 'a) => 'b) => t<'b> | ||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: ar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
적용했습니다! e9d07ff