Skip to content

[v17] Add fork after authentication for tsh ssh #55894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

atburke
Copy link
Contributor

@atburke atburke commented Jun 18, 2025

Backport #54696 to branch/v17

Changelog: Added fork after authentication to tsh ssh

@github-actions github-actions bot added backport size/lg tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Jun 18, 2025
This change adds fork after authentication support
to tsh ssh.
@atburke atburke force-pushed the atburke/v17/ssh-fork-auth branch from 318b601 to 3fc2c2c Compare June 19, 2025 00:39
@atburke
Copy link
Contributor Author

atburke commented Jun 19, 2025

dnm until I fix compilation on linux/arm64

@camscale
Copy link
Contributor

@atburke b3a3066 can be cherry-picked into this PR for the arm64 build fix. Master successfully built overnight.

* tsh: Add wrapper for syscall.Dup2 for linux/arm64

Add a wrapper for `syscall.Dup2()` as linux ARM64 does not have that
syscall. On that platform, `syscall.Dup3()` needs to be used instead.

Fixes: 57c909d

* Implement dup2 with syscall.Dup3 on all linux platforms

* Add explicit "unix" constraint to dup2_unix.go to ensure Windows is excluded
@atburke atburke enabled auto-merge June 24, 2025 00:58
@atburke atburke added this pull request to the merge queue Jun 24, 2025
Merged via the queue into branch/v17 with commit 5d6b285 Jun 24, 2025
39 checks passed
@atburke atburke deleted the atburke/v17/ssh-fork-auth branch June 24, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/lg tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants