MWI: Add audit events for bound keypair joining #55701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyb89
force-pushed
the
timothyb89/bound-keypair-enforce-generation-counter
branch
from
492e734 to
e1e3c19
Compare
Base automatically changed from
timothyb89/bound-keypair-enforce-generation-counter
to
master
June 17, 2025 17:30
timothyb89
force-pushed
the
timothyb89/bound-keypair-audit-events
branch
from
5b457ab to
106c0df
Compare
timothyb89
added
no-changelog
|
@timothyb89 - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
github-actions
bot
added
audit-log
This adds 3 new audit events for bound keypair joining: - `join_token.bound_keypair.recovery` - emitted when a join triggers a recovery (first join, or join with expired certs) - `join_token.bound_keypair.rotation` - emitted when a keypair rotation takes place - `join_token.bound_keypair.join_state_verification_failed` - emitted when the client provides an invalid join state document
timothyb89
force-pushed
the
timothyb89/bound-keypair-audit-events
branch
from
88e8e17 to
8731de0
Compare
|
review note: I removed the event schema update ( |
strideynet
approved these changes
Jun 23, 2025
boxofrad
approved these changes
Jun 23, 2025
gzdunek
approved these changes
Jun 23, 2025
…ypair-audit-events
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 3 new audit events for bound keypair joining:
join_token.bound_keypair.recovery- emitted when a join triggers a recovery (first join, or join with expired certs)join_token.bound_keypair.rotation- emitted when a keypair rotation takes placejoin_token.bound_keypair.join_state_verification_failed- emitted when the client provides an invalid join state documentThis also cleans up and obscures various error messages returned to clients since we now log more specific explanations for why a recovery/rotation/verification failed.