Skip to content

[graphiql] remove unused dependencies graphql-language-service and markdown-it #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Jul 24, 2024

they are used in @graphiql/react but not in graphiql

Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: acac8cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao
Copy link
Member

acao commented Aug 1, 2024

@dimaMachina the others seem fine, however @graphiql/toolkit is used by graphiql here:

packages/graphiql/src/cdn.ts

i imagine this is why the e2e suite is failing

@dimaMachina
Copy link
Collaborator Author

@acao tests failed due dedup of markdown-it, was fixed by adding overrides in package.json

[webpack-dev-server] ERROR in ../../../node_modules/markdown-it/lib/common/entities.js 6:0-59
Module not found: Error: Package path ./lib/maps/entities.json is not exported from package /Users/dmytro/Desktop/GUILD/graphiql/node_modules/entities (see exports field in /Users/dmytro/Desktop/GUILD/graphiql/node_modules/entities/package.json)

@dimaMachina dimaMachina merged commit 5450e6b into graphql:main Aug 2, 2024
14 checks passed
@dimaMachina dimaMachina deleted the graphiql-remove-unused-dependencies branch August 2, 2024 09:01
@acao acao mentioned this pull request Aug 2, 2024
@acao acao mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants