fix: move ++ opertator to the front & cleanup useEffect #336
Conversation
|
@IvanGoncharov Could you have a look at this whenever you have the time please? It will fix a bug people are having currently rendering graphs |
|
@IvanGoncharov , Could you please have a look and approve.. cc @MitchWijt |
|
I am so sorry, but we are in the tight deadline to achieve the voyager feature into out backstage developer portal. could you please approve and merge this PR, so that we can TEST. Thanks @IvanGoncharov , Could you please have a look and approve.. cc @MitchWijt |
@MitchWijt I don't get what the problem is here, can you please explain with more details? |
| if(isMounted) { | ||
| setIntrospectionData(data); | ||
| setSelected({ typeID: null, edgeID: null }); | ||
| } |
There was a problem hiding this comment.
Can you please explain what you are fixing here?
|
@MitchWijt This issue is already fixed here: |
|
@IvanGoncharov The problem comes forth over here: backstage/backstage#18736 The isMounted fixes the error
|
|
@IvanGoncharov @MitchWijt |
|
@IvanGoncharov does the above comment make sense to you? |
|
@IvanGoncharov Will these changes be published to NPM any time soon? |
|
@MitchWijt I will try to publish something today. |
This PR fixes the SVG renderer.
Previous the listener
idindex was being incremented by doingid++. However this returns the unincremented result. Meaning ifid = 0.id++will return 0. The id never got incremented, causing the function to crash.Second bug fix is cleaning up the useEffect function in the Voyager component, this was causing errors.