Skip to content

fix: issue: [2717] coverage calculation improvements #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2024

Conversation

DanteUkraine
Copy link
Contributor

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

As a user of coverage feature I faced need to see total and covered numbers of queries and mutations.
So I decided to apply improvements.

Fixes # (2717)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

I updated existing unit tests.

Test Environment:

  • OS:
  • @graphql-inspector/...:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

Copy link

changeset-bot bot commented May 30, 2024

🦋 Changeset detected

Latest commit: f52942a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@graphql-inspector/coverage-command Minor
@graphql-inspector/core Minor
@graphql-inspector/cli Patch
@graphql-inspector/action Patch
@graphql-inspector/audit-command Patch
@graphql-inspector/diff-command Patch
@graphql-inspector/introspect-command Patch
@graphql-inspector/similar-command Patch
@graphql-inspector/validate-command Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DanteUkraine
Copy link
Contributor Author

@TuvalSimha New PR with my changes only, #2775

@TuvalSimha TuvalSimha self-requested a review May 30, 2024 11:05
@TuvalSimha TuvalSimha merged commit 0e40ebd into graphql-hive:master May 30, 2024
5 checks passed
@TuvalSimha
Copy link
Collaborator

@DanteUkraine thank you very much! great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants