Bump @graphql-tools/load to v8.1.0 #1725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uyend
approved these changes
Apr 13, 2025
dotansimha
approved these changes
Apr 14, 2025
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps
@graphql-tools/loadto^8.1.0@graphql-tools/[email protected]is released after this PR with an improvement to error handling.Whilst integrating with dotansimha/graphql-code-generator#10338 to fix error handling, I noticed existing consumers may get into a state where
graphql-configbrings@graphql-tools/loadlower than 8.1.0, but the codepath that uses@graphql-tools/loaddirectly brings in 8.1.0. This causes inconsistency with error message.We technically don't have to do this in
graphql-config, however, this change ensures both code paths work the same way without consumers having to do anything.Type of change