Pass an object rather than a handle to the note editor callback #2070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
Nick-Hall
changed the title
Nick-Hall
changed the title
This gives consistency with other Edit classes. Adjust other code accordingly. Fixes #13702.
Nick-Hall
merged commit 1b68f87
into
gramps-project:maintenance/gramps60
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix EditNote so that it passes the object when calling the callback function, rather than the object handle.
Fixes the error described in 13702 and gives consistency with other Edit classes.
To reproduce:
Fixes #13702 and possibly #12260
Reviewed and adjusted other places that create an EditNote instance with callback