Fix broken compound dates with bce year in XML import #2067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prculley CI build failure may have been a transient issue. Since I don't know how to kick off a new CI build, I'm thinking closing the PR and re-opening it will trigger it, if you want to try it. |
Nick-Hall
changed the title
Fixes #13631.
Nick-Hall
changed the title
Nick-Hall
merged commit 634e5cc
into
gramps-project:maintenance/gramps60
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If date spans have a negative year, the import of the date fails and converts to a text string.
A similar issue was fixed for normal dates and I copied the solution.
The issue goes back a ways, I found it in gramps52... Might want to look into back porting this.
Fixes #13631.