Skip to content

Fix crash in Citation View #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stevenyoungs
Copy link
Contributor

Fix a crash in Citation View will when sorting by "Last Changed" date.

To reproduce:

  1. Start with Gramps60 branch with Bug: Fix crash in SearchBar #2060 in place.
  2. Preconditions: in Citation View, Sidebar turned off (Menu/View/Sidebar). Configure the view so "Last Changed" is visible.
  3. Open a tree with some citations.
  4. In Citation View, click on "Last Changed" column to resort it.

Fixes bug 0013796

@Nick-Hall
Copy link
Member

Please keep changes in bug fixes to a minimum. Renaming variables and adding type checking are not required to fix the bug.

@Nick-Hall Nick-Hall added the bug label May 13, 2025
@stevenyoungs
Copy link
Contributor Author

Let me know if you want me to split this PR. I kept the commits separate for this eventuality. Only the first one is required for 6.0

@dsblank dsblank added this to the v6.0 milestone Jun 7, 2025
@Nick-Hall Nick-Hall merged commit 7a3a2bc into gramps-project:maintenance/gramps60 Jun 9, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants