Skip to content

Incorrect addons project after upgrade from Gramps 5.2 #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

prculley
Copy link
Contributor

@prculley prculley commented May 8, 2025

Upgrades from older Gramps (Gramps v5.2.x) copy the gramps.ini from the older version, including the "behaviour.addons-projects" values, which then point to the older github addons. This fixes that.

Fixes #13789.

@prculley prculley added the bug label May 8, 2025
@emyoulation
Copy link
Contributor

@emyoulation
Copy link
Contributor

emyoulation commented May 8, 2025

Instead of resetting to defaults, could this just deselect all but the 1st (default) "Project" rather than flushing the row? (Upgrade warning dialogs are generally undesirable since they disrupt the workflow but... perhaps pop a Warning on gramps.ini import that Addon "Projects" need to be updated?)

This would allow users to Edit the URL to a current version path without having to find the URL or remember which Projects that they had added.

Also, if the Addon Manager becomes smarter about not trying to install gramps_target_version addons that are mismatches, then the JSON might have mixed sets of gramps_target_version rows. ( I do not know how the "major_version" hack in Isotammi .gpr.py will work/fail with smarter gramps_target_version attribute handling.)

Also, if a URL Validator enhancement (as suggested in 13069) is added, then this routine could 'invalidate' as well as deselect project rows.

There are a series of Addon Manager feature requests and bugs (with some duplication) linked to:
https://gramps-project.org/bugs/view.php?id=13069

@dsblank dsblank added this to the v6.0 milestone Jun 7, 2025
@Nick-Hall Nick-Hall changed the title Fixes #0013789 Incorrect addons project after upgrade from Gramps 5.2 Incorrect addons project after upgrade from Gramps 5.2 Jun 9, 2025
@Nick-Hall Nick-Hall merged commit dfa1ff2 into gramps-project:maintenance/gramps60 Jun 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants