Respect user choice of CSS files for existing narrated web site #2057
Conversation
|
@SNoiraud This address defect 13792 and I would like your review on it. There are other files being copied to the output folder which are not overwritten either; should all of them be overwritten in case of changes, or stick with just this one file? |
|
@Nick-Hall Happy to hear your thoughts on this as well. If @SNoiraud doesn't have strong thoughts, I can remove the draft status as-is. |
|
The origin of this: |
|
@SNoiraud Thanks for confirming the rationale for current behavior. Reading in-between the lines, I take you would prefer to make minimal changes and overwrite only this file and not the others. Removed draft status of PR; it is ready for further review and merging. @Call-Me-Dave Open to your comments on this PR in the context of the bug report if you would verbalize them. |
|
The fix was tested and validated by reporter on Linux, and validated by me on Windows as well. Ready to merge. |
It was meant to be a thumbs up emoticon to represent that I like this 👍 |
When a narrated web site is generated to an existing folder and the CSS for the web pages is changed, the screen CSS would not be overwritten. This has been changed so that the user's choice of CSS is correctly copied to the output directory. Fixes #13792.
Nick-Hall
force-pushed
the
bug-13792-gramps60
branch
from
4cc416c to
828a1f6
Compare
Nick-Hall
changed the title
Nick-Hall
merged commit 828a1f6
into
gramps-project:maintenance/gramps60
Fixes #13792
When a Narrated Web Site is generated to an existing folder and the CSS for the web pages is changed, the screen CSS would not be overwritten. This has been changed so that the user's choice of CSS is correctly copied to the output directory