Fix exception handling in plugins/webreport when importing icu/PyICU #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If neither icu nor PyICU is installed then a failure like this
results:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/gramps/gen/plug/_manager.py", line 270, i
n load_plugin
_module = self.import_plugin(pdata)
File "/usr/lib/python3/dist-packages/gramps/gen/plug/_manager.py", line 333, i
n import_plugin
module = __import__(pdata.mod_name)
File "/usr/lib/python3/dist-packages/gramps/plugins/webreport/narrativeweb.py"
, line 109, in <module>
from gramps.plugins.webreport.basepage import BasePage
File "/usr/lib/python3/dist-packages/gramps/plugins/webreport/basepage.py", li
ne 108, in <module>
from gramps.plugins.webreport.common import (
...<10 lines>...
)
File "/usr/lib/python3/dist-packages/gramps/plugins/webreport/common.py", line
682, in <module>
AlphabeticIndex = localAlphabeticIndex # type: ignore[misc, assignment]
^^^^^^^^^^^^^^^^^^^^
NameError: name 'localAlphabeticIndex' is not defined
To avoid this, fall back to importing from local alphabeticindex.py.
Now it would be possible to remove the inner try: when importing
PyICU, since this change will also catch the exception there.
However, that should probably be done as a separate change, since the
current fix is minimal and clear.
Fixes #13407
Signed-off-by: Martin Schwenke <[email protected]>
Signed-off-by: Martin Schwenke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception handling is currently incomplete when both icu and PyICU are not installed.
First, fix the error in the most obvious way. Then remove duplicate exception handling.