Allow Multiple Selection from People, Event and Note Selectors #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenyoungs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from PR #1836 which added multiple selection of media objects in the gallerytab, allow multiple selection of
NotesTabEventEmbedListAs with the gallery tab, if multiple objects are selected, the references are added without showing the edit ref dialog.
It would be nice to permit multiple selection of citations but currently the multiple selection would permit multiple sources, or sources and citations, to be returned and it is not clear what the user experience should be in this scenario. So for now, I've left it as single selection.