fix: use renderName for scalar types to escape TypeScript reserved keywords #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reserved keywords Fixes scalar type generation to properly escape TypeScript reserved keywords like 'bigint' by using the existing renderName() function. This prevents compilation errors when GraphQL schemas contain scalars with reserved names. Fixes #1354
jasonkuhrt
force-pushed
the
fix/reserved-scalar-names
branch
from
94c789e to
4c487bc
Compare
Add tests that demonstrate the issue where scalar names that are TypeScript reserved keywords (like 'bigint', 'boolean') generate invalid TypeScript code. The fix is commented out with TODO markers. Issue #1354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1354
Summary
bigintare generated as$bigintto avoid conflictsProblem
When a GraphQL schema contains a scalar with a name that matches a TypeScript reserved keyword (like
bigint), the generated code would fail to compile with errors like:Solution
renderName()function in the scalar generator$