Skip to content

feat: add debugger support #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2024
Merged

feat: add debugger support #37

merged 3 commits into from
Feb 28, 2024

Conversation

theSuess
Copy link
Contributor

This implements support for debugging jsonnet files based on google/go-jsonnet#739.

The installation works the same way as the language server. By default, the following repository is used: https://github.com/grafana/jsonnet-debugger

The current checked in files were formatted inconsistently, that's why there's such a large diff.

Summarized Changes:

  • Add parameters to install function
  • register debug provider
  • register dynamic debug configurations

@theSuess
Copy link
Contributor Author

I've only tested it locally on linux so it would need some testing on MacOS and Windows to make sure everything works

Copy link
Collaborator

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, looks amazing. Can we do the reformatting in a different PR, with an editorconfig if possible?

@theSuess
Copy link
Contributor Author

Opened #38 to get to consistent formatting. Will rebase this after it's merged.

@theSuess theSuess marked this pull request as draft February 26, 2024 08:28
@theSuess theSuess marked this pull request as ready for review February 27, 2024 08:03
@julienduchesne julienduchesne merged commit f6cf4d8 into main Feb 28, 2024
@julienduchesne julienduchesne deleted the feat/add-debugger branch April 29, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants