Always use non-symlinked paths when listing imports. #302
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Havin a "canonical" representation of the imports makes the life much easier when trying to match environment's dependencies against a list of changed jsonnet/libsonnet files. Signed-off-by: Milan Plzik <[email protected]>
mplzik
force-pushed
the
mplzik/non-symlinked-imports
branch
from
d5f8cbf to
6c19734
Compare
mplzik
added a commit
that referenced
this pull request
Jun 26, 2020
The change in #302 only removed symlinks from the directory path for `main.jsonnet`; this commit also modifies the code that iteratoes through all the transitive dependencies to de-symlink them. Signed-off-by: Milan Plzik <[email protected]>
sh0rez
pushed a commit
that referenced
this pull request
Jun 30, 2020
The change in #302 only removed symlinks from the directory path for `main.jsonnet`; this commit also modifies the code that iteratoes through all the transitive dependencies to de-symlink them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Havin a "canonical" representation of the imports makes the life much
easier when trying to match environment's dependencies against a list of
changed jsonnet/libsonnet files.