Implement sorting by NS and test object sorting. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the original sort code in Reconcile() didn't take into account the case where two objects of the same kind and name might reside in different namespace, allowing the sort being non-deterministic at times. - testing of the sort code is now implemented. There might be some refactor pending, since `kubernetes_test.go` also contains code testing `Reconcile()`, but this is outside the scope of this PR. Signed-off-by: Milan Plzik <[email protected]>
mplzik
force-pushed
the
mplzik/test-object-sorting
branch
from
63194c9 to
3a18c9d
Compare
- Refactored `mkobj` to look nicer. - Added a testcase that tests prioritizing Kind -> Namespace -> Name, in that order. Signed-off-by: Milan Plzik <[email protected]>
|
@sh0rez changes implemented; PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the original sort code in Reconcile() didn't take into account
the case where two objects of the same kind and name might reside in
different namespace, allowing the sort being non-deterministic at
times.
testing of the sort code is now implemented.
There might be some refactor pending, since
kubernetes_test.goalsocontains code testing
Reconcile(), but this is outside the scope ofthis PR.