Skip to content

fix(cli): show diff on apply instead of it's pointer #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2020
Merged

fix(cli): show diff on apply instead of it's pointer #200

merged 1 commit into from
Feb 9, 2020

Conversation

davidovich
Copy link
Contributor

@davidovich davidovich commented Feb 9, 2020 •
edited
Loading

closes #199

@tombrk tombrk changed the title Print the content of string instead of its address fix(cli): show diff on apply instead of it's pointer Feb 9, 2020
tombrk
tombrk approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@tombrk tombrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombrk tombrk merged commit b5fd1cc into grafana:master Feb 9, 2020
@tombrk tombrk mentioned this pull request Feb 9, 2020
Closed
@davidovich davidovich deleted the fix-diff-output-before-apply branch February 9, 2020 22:24
@tombrk tombrk mentioned this pull request Feb 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombrk tombrk tombrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tk apply shows a pointer address before applying, instead of showing the diff result
2 participants
@davidovich @tombrk