Skip to content

Chart.yaml version should be parsed as semver so that matching it against requirements from chartfile.yaml works properly #701

Closed
@kklimonda-fn

Description

@kklimonda-fn

version for charts defined in chartfile.yaml is parsed via semver module, but version from any given chart's Chart.yaml is not, instead we do a string comparison: if chartYAML.Version == r.Version.String() {

This breaks for charts that are not 100% compliant with semver spec, and prefix version with v, for example jetstack/cert-manager defines version as v1.8.0 and currently this is never correctly matched by tanka, resulting in the chart being re-downloaded on every tk tool charts vendor run.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions