Confirmation prompt not working on Windows

[JohnRusk]

Here's an example (running from Windows Powershell)

>tk apply environments/default
Applying to namespace <REDACTED>
Please type 'yes' to confirm: yes
aborted by user

Notice that when I type "yes", tk replies with "aborted by user".

A (temporary) workaround is to add the --dangerous-auto-approve flag. (I like the name, by the way!)

[issue-label-bot]

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[sh0rez]

This is probably related to this code:

tanka/pkg/term/alert.go

Lines 16 to 23 in 931373a

	read, err := reader.ReadString('\n')
	if err != nil {
	return errors.Wrap(err, "reading from stdin")
	}
	if read != approval+"\n" {
	return errors.New("aborted by user")
	}
	return nil

Probably the different line endings on Windows are the problem. It would need \r\n.

However, it seems like there is no os constant in Go for this?!

[JohnRusk]

Yeah, I don't think there is a constant. But this would presumably work:

if strings.Trim(read, "\r\n") != approval {   // trim all EOL chars from read, instead of adding any to approval
    return ....

[sh0rez]

Good idea! Wanna try that out and if it works, create a PR?

[JohnRusk]

Will do.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[JohnRusk]

Thanks for the reminder, StaleBot. I'm struggling to find time for this. May or may not get to it. Sorry about that sh0rez.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[nlowe]

This is still a problem in the most recent release and should be re-opened.

[JohnRusk]

Nice @sh0rez . Sorry I never got time to attempt doing this for you!