Skip to content

Create plugin: Update release workflow template to include attestation by default #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Create plugin: Update release workflow template to include attestation by default #1539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef80c04
Create plugin: Update release workflow template to include attestatio…
academo Feb 12, 2025
8e8d0b7
Merge branch 'main' into academo/default-attestation-on
academo Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/create-plugin/templates/github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,17 @@ permissions: read-all
jobs:
release:
permissions:
id-token: write
contents: write
attestations: write
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: grafana/plugin-actions/build-plugin@main
# Uncomment to enable plugin signing
# (For more info on how to generate the access policy token see https://grafana.com/developers/plugin-tools/publish-a-plugin/sign-a-plugin#generate-an-access-policy-token)
#with:
with:
attestation: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this was already asked within the team but will this cause issues with private repositories?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about the same thing. What would happen if you run this in a private repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use artifact attestations in private or internal repositories, you must be on a GitHub Enterprise Cloud plan.

that's what github says.

# Uncomment to enable plugin signing
# (For more info on how to generate the access policy token see https://grafana.com/developers/plugin-tools/publish-a-plugin/sign-a-plugin#generate-an-access-policy-token)
# Make sure to save the token in your repository secrets
#policy_token: ${{ secrets.GRAFANA_ACCESS_POLICY_TOKEN }}
# Usage of GRAFANA_API_KEY is deprecated, prefer `policy_token` option above
Expand Down
Loading