Upgrade Prometheus to 59d02b5ef003f125286a62aa6daf4c8b7583042f #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <[email protected]>
codesome
force-pushed
the
codesome/upgrade-prom
branch
from
b9708f9 to
5b3a2a5
Compare
Signed-off-by: Ganesh Vernekar <[email protected]>
codesome
force-pushed
the
codesome/upgrade-prom
branch
from
f3ca6ad to
b2ea888
Compare
codesome
commented
Jul 20, 2021
Comment on lines
+1569
to
+1572
| enableExemplars := false | ||
| if i.cfg.BlocksStorageConfig.TSDB.MaxExemplars > 0 { | ||
| enableExemplars = true | ||
| } |
There was a problem hiding this comment.
Additionally, we could always keep it enabled and resize the exemplar storage when needed (this upgrades brings in the Resize function on exemplar storage).
There was a problem hiding this comment.
For now, it's fine to keep it disabled if MaxExemplars = 0.
pracucci
approved these changes
Jul 20, 2021
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| * [CHANGE] Removed `configdb` support from Ruler and Alertmanager backend storages. #15 | |||
| * [CHANGE] Changed `-ruler.storage.type` default value from `configdb` to `local`. #15 | |||
| * [CHANGE] Changed `-alertmanager.storage.type` default value from `configdb` to `local`. #15 | |||
| * [ENHANCEMENT] Prometheus upgraded. #4 #16 | |||
There was a problem hiding this comment.
I made it a BUGFIX since this is a important bugfix for the bug that we are hitting. Does the wording look fine?
Signed-off-by: Ganesh Vernekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Upgrades Prometheus to prometheus/prometheus@59d02b5 to get prometheus/prometheus#9081 in
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]