feat(rw2): prepare for RW2 support #11101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
force-pushed
the
krajo/rw2-proto
branch
3 times, most recently
from
75e43e8 to
f8cdc7e
Compare
Add the RW2 proto definition to mimirpb. The implementation will follow but it needs to patch the generated files, so we commit the proto now to have actually readable diff in the PR that has the functionality. See #10423 and especially #11100 diff. Signed-off-by: György Krajcsovits <[email protected]>
krajorama
force-pushed
the
krajo/rw2-proto
branch
from
f8cdc7e to
5f5c451
Compare
Signed-off-by: György Krajcsovits <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pkg/mimirpb/mimir.pb.go.expdiff: Language not supported
Comments suppressed due to low confidence (1)
pkg/util/test/shape.go:60
- [nitpick] Consider removing the leading whitespace in the format string to avoid unexpected formatting in the output.
return fmt.Sprintf(" protobuf:%s,%s", tokens[0], tokens[1])
aknuds1
approved these changes
Apr 4, 2025
Co-authored-by: Copilot <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Remote Write 2.0 proto definition to mimirpb. The implementation of Remote Write 2.0 will follow but it needs to patch the generated files, so we commit the proto now to have actually readable diff in the PR that has the functionality.
See #11100 diff.