Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Go to use Go1.16 #165

Merged
merged 2 commits into from
Apr 9, 2021
Merged

chore: update Go to use Go1.16 #165

merged 2 commits into from
Apr 9, 2021

Conversation

jtlisi
Copy link
Contributor

@jtlisi jtlisi commented Apr 8, 2021 •
edited
Loading

Blocked until cortexproject/cortex#4062 is merged

  • Use Go 1.16 for all images and CICD fixtures

@jtlisi jtlisi mentioned this pull request Apr 8, 2021
Merged
@jtlisi jtlisi marked this pull request as ready for review April 9, 2021 15:59
@jtlisi jtlisi requested a review from a team as a code owner April 9, 2021 15:59
simonswine
simonswine approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not actually too sure at which point you need to upgrade this:

cortex-tools/go.mod

Line 3 in 34d65b8

go 1.14

@jtlisi
update go.mod to Go 1.16
4c89cf9 
Signed-off-by: Jacob Lisi <[email protected]>
@jtlisi jtlisi merged commit ebeed6b into main Apr 9, 2021
@jtlisi jtlisi deleted the 2021w14_go1.16 branch April 9, 2021 17:43
@simonswine simonswine mentioned this pull request Jan 7, 2022
Merged
simonswine pushed a commit to grafana/mimir that referenced this pull request Jan 12, 2022
@jtlisi
chore: update Go to use Go1.16 (grafana/cortex-tools#165)
3577789 
* chore: update Go to use Go1.16

Signed-off-by: Jacob Lisi <[email protected]>

* update go.mod to Go 1.16

Signed-off-by: Jacob Lisi <[email protected]>
friedrichg pushed a commit to cortexproject/cortex-tools that referenced this pull request Aug 1, 2023
@nschad
ServiceMonitors: add options to configure metric- and relabelings (gr…
5cd8222 
…afana#165)

* add honorLabels=true and options to configure metric- and relabelings

Signed-off-by: ShuzZzle <[email protected]>

* add CHANGELOG

Signed-off-by: ShuzZzle <[email protected]>

* remove honorLabels=true

Signed-off-by: ShuzZzle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtlisi @simonswine