Add a new mimir.alerts.kubernetes component #3448
Draft
+2,773
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
5 tasks
ptodev
commented
Apr 25, 2025
Comment on lines
+1031
to
+1096
| // TODO: Upstream this change prior to merging the mimir.alerts.kubernetes component to main. | ||
| replace github.com/prometheus-operator/prometheus-operator => github.com/ptodev/prometheus-operator v0.0.0-20250425071154-e2ee3c49b414 |
There was a problem hiding this comment.
I will need to merge a PR upstream before I merge this feature.
ptodev
force-pushed
the
504-listen-for-alertmanagerconfig-crds-and-configure-alertmanager-in-grafana-mimircortex
branch
2 times, most recently
from
46e4b8d to
9a02eae
Compare
ptodev
force-pushed
the
504-listen-for-alertmanagerconfig-crds-and-configure-alertmanager-in-grafana-mimircortex
branch
from
9a02eae to
ca15a30
Compare
|
💻 Deploy preview available: |
ptodev
force-pushed
the
504-listen-for-alertmanagerconfig-crds-and-configure-alertmanager-in-grafana-mimircortex
branch
2 times, most recently
from
d9f76dd to
74de2da
Compare
ptodev
force-pushed
the
504-listen-for-alertmanagerconfig-crds-and-configure-alertmanager-in-grafana-mimircortex
branch
from
2de59c8 to
cb30ab7
Compare
|
hi! we would interested in using this - what's the plan to merge it ? |
|
Hi @vladst3f! I'm still hopeful that this can go into the next Alloy release. However, I had a lot of trouble updating the go.mod file last time I tried to update the PR. There was a dependency which another one of Alloy's dependencies wanted on the latest version but other dependencies weren't compatible with the latest version. I might need to fork some dependencies in order to merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Which issue(s) this PR fixes
Fixes #504
Notes to the Reviewer
PR Checklist