Lowercase scheme for Prometheus ScrapeConfig #3446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ptodev
approved these changes
Apr 28, 2025
|
LGTM, thank you! We have a few issues with our CI since we're rotating a few CI parameters at the moment... we can merge this change in a day or two when the CI is working well and after the branch is rebased. |
This fixes grafana#3386 Signed-off-by: alex-berger <[email protected]>
alex-berger
force-pushed
the
fix/scape-config-schema-casing
branch
from
574114e to
4e92ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus Operator ScrapeConfig CRD requires
spec.schemeto be uppercase"HTTP" or"HTTPS", but the implementation expects lowercase"http"or"https"` in the final scrape configuration.PR Description
Which issue(s) this PR fixes
Fixes #3386
Notes to the Reviewer
PR Checklist